ADR 013: bolt_agent, Bolt 5.3 #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the default `user_agent` to conform the new common format * Added support for Bolt 5.3 with the new `bolt_agent` string
tests/stub/driver_parameters/scripts/v5x3/user_agent_custom.script
Outdated
Show resolved
Hide resolved
tests/stub/driver_parameters/scripts/v5x3/user_agent_custom.script
Outdated
Show resolved
Hide resolved
injectives
reviewed
Apr 12, 2023
thelonelyvulpes
approved these changes
Apr 13, 2023
As the ADR got updated the tests needed adjusting: * `user_agent` remains untouched * `bolt_agent` becomes a dictionary instead of a string Also added empty user_agent as test case.
thelonelyvulpes
changed the title
robsdedude
commented
May 23, 2023
tests/stub/driver_parameters/scripts/v5x3/user_agent_custom.script
Outdated
Show resolved
Hide resolved
tests/stub/driver_parameters/scripts/v5x3/user_agent_default.script
Outdated
Show resolved
Hide resolved
fbiville
approved these changes
May 23, 2023
* Bolt 5.3 will be released with Neo4j 5.9, not 5.8. * Copy paste mistake in version test stub scripts Signed-off-by: Rouven Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bolt_agentstring